Fix ordering of Kotlinx Serialization CodecCustomizer#50428
Open
dmitrysulman wants to merge 1 commit into
Open
Fix ordering of Kotlinx Serialization CodecCustomizer#50428dmitrysulman wants to merge 1 commit into
dmitrysulman wants to merge 1 commit into
Conversation
…fter it Signed-off-by: Dmitry Sulman <dmitry.sulman@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kotlinx Serialization
CodecCustomizerintroduced in d161aaf lacks an explicit order, meaning it defaults toLOWEST_PRECEDENCE. This prevents user-provided customizers from overriding Spring Boot defaults, as the default customizer runs last and overwrites previous configurations.A similar issue for message converters was fixed in 3948e7c. The Jackson
CodecCustomizeris already explicitly ordered:spring-boot/module/spring-boot-http-codec/src/main/java/org/springframework/boot/http/codec/autoconfigure/CodecsAutoConfiguration.java
Lines 68 to 77 in 21a3eec
This PR adds
@Order(0)to thekotlinxJsonCodecCustomizerbean to address this issue.See #48070 and #48609
@bclozel fyi